chore: Clean up Nextjs-example with postcss-plugin #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
necolas
reviewed
Nov 27, 2024
| */ | ||
|
|
||
| /** | ||
| * The @stylex directive is used by the @stylexjs/postcss-plugin. |
There was a problem hiding this comment.
You should have kept this comment when moving the directive, otherwise it's not going to be clear what it means to people just browsing the nextjs code example
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
* chore: Clean up Nextjs-example with postcss-plugin * chore: remove unnecessary 'bright' dep * chore: add json-scheme types
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
* chore: Clean up Nextjs-example with postcss-plugin * chore: remove unnecessary 'bright' dep * chore: add json-scheme types
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
* chore: Clean up Nextjs-example with postcss-plugin * chore: remove unnecessary 'bright' dep * chore: add json-scheme types
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
* chore: Clean up Nextjs-example with postcss-plugin * chore: remove unnecessary 'bright' dep * chore: add json-scheme types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: Just makes some small tweaks to the Next.js example to simplify the setup now that we have the postcss-plugin.