docs: Migrate docs pm to npm from yarn #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
necolas
approved these changes
Dec 6, 2023
| @@ -6,24 +6,28 @@ This website is built using [Docusaurus 2](https://docusaurus.io/), a modern sta | |||
|
|
|||
| - stylex actual package, and then the @stylexjs/babel-plugin plugin in node_modules | |||
|
|
|||
| ```bash | |||
| $ npm run build -w @stylexjs/stylex -w @stylexjs/shared -w @stylexjs/eslint-plugin -w @stylexjs/babel-plugin | |||
There was a problem hiding this comment.
npm run build --workspaces is all that's needed
There was a problem hiding this comment.
That builds all the packages/apps in the workspace, the documentation above only mentions the stylex packages and eslint plugin, so I only added builds that are required for docs to run (minimizes build time for first time contributors looking to only contribute to docs as size of monorepo increases). I could change it to build the entire workspace if that is the desired behavior 😀
|
Thanks for these great PRs @kevintyj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
I noticed that the project was mainly using npm, however, the docs app (website) was using yarn. I have edited the package.json to migrate yarn commands to npm and updated README to reflect the changes
Linked PR/Issues
None
Additional Context
stylelint-copyrightandlint & cicommands seems to fail. Was not sure if this was expected behavior and if the linter is only ran on ci.**/build/**to stylelint (was not sure if this is a desired behavior)Pre-flight Checklist