Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: border-left not being rendered #128

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix: border-left not being rendered #128

merged 2 commits into from
Dec 11, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 11, 2023

What changed / motivation ?

The application-order style mergin strategy was accidentally not generating styles for border-left and border-inline-start. This PR fixes that.

Linked PR/Issues

#127

Additional Context

Added a unit test for this

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2023
Copy link

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Dec 11, 2023

compressed-size: e2e bundles

Size change: -3.12 kB
Total size: 1122.94 kB

Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 998.63 (9939.85) -6.72 (+80.36) -0.7% (+0.8%) 🟢
./apps/rollup-example/.build/stylex.css 124.30 (874.43) +3.60 (+3.52) +3.0% (+0.4%) 🔴

@nmn nmn merged commit f9f6ede into main Dec 11, 2023
8 checks passed
@nmn nmn deleted the fix-border-left branch December 11, 2023 19:56
@huseyinsalmansoftdev
Copy link

I am using the 0.3.0 version with vite and vite-plugin-stylex. The reason I am using this version is because the plugin throws an error with the latest version. Everything was working fine but I realized borderLeft is not getting recognized. I can see that there is a fix. Is this fix present in 0.3.0 version? Do I have to do anything manually to solve this?

@nmn
Copy link
Contributor Author

nmn commented Jan 4, 2024

@huseyinsalmansoftdev I understand that there is an issue with 0.4.1 and Vite. You can use borderInlineStart instead of borderLeft as a workaround for now. Fix for 0.4.1 and Vite is coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants