Perf: Remove runtime injection from runtime (#163)

facebook · Dec 14, 2023 · f5e9b5e · f5e9b5e
1 parent 5ee758d
commit f5e9b5e
Show file tree

Hide file tree

Showing 28 changed files with 1,631 additions and 1,008 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/babel-plugin/__tests__/evaluation/stylex-import-evaluation-test.js b/packages/babel-plugin/__tests__/evaluation/stylex-import-evaluation-test.js
@@ -65,10 +65,11 @@ describe('Evaluation of imported values works based on configuration', () => {
       );
       expect(transformation.code).toContain(expectedVarName);
       expect(transformation.code).toMatchInlineSnapshot(`
-        "import stylex from 'stylex';
+        "import _inject from "@stylexjs/stylex/lib/stylex-inject";
+        import stylex from 'stylex';
         import 'otherFile.stylex';
         import { MyTheme } from 'otherFile.stylex';
-        stylex.inject(".__hashed_var__1r7rkhg{color:var(--__hashed_var__1jqb1tb)}", 3000);
+        _inject(".__hashed_var__1r7rkhg{color:var(--__hashed_var__1jqb1tb)}", 3000);
         "__hashed_var__1r7rkhg";"
       `);
       expect(transformation.metadata.stylex).toMatchInlineSnapshot(`
@@ -103,10 +104,11 @@ describe('Evaluation of imported values works based on configuration', () => {
       );
       expect(transformation.code).toContain(expectedVarName);
       expect(transformation.code).toMatchInlineSnapshot(`
-        "import stylex from 'stylex';
+        "import _inject from "@stylexjs/stylex/lib/stylex-inject";
+        import stylex from 'stylex';
         import 'otherFile.stylex.js';
         import { MyTheme } from 'otherFile.stylex.js';
-        stylex.inject(".__hashed_var__1r7rkhg{color:var(--__hashed_var__1jqb1tb)}", 3000);
+        _inject(".__hashed_var__1r7rkhg{color:var(--__hashed_var__1jqb1tb)}", 3000);
         "__hashed_var__1r7rkhg";"
       `);
       expect(transformation.metadata.stylex).toMatchInlineSnapshot(`
@@ -141,10 +143,11 @@ describe('Evaluation of imported values works based on configuration', () => {
       );
       expect(transformation.code).toContain(expectedVarName);
       expect(transformation.code).toMatchInlineSnapshot(`
-        "import stylex from 'stylex';
+        "import _inject from "@stylexjs/stylex/lib/stylex-inject";
+        import stylex from 'stylex';
         import 'otherFile.stylex.js';
         import { MyTheme as mt } from 'otherFile.stylex.js';
-        stylex.inject(".__hashed_var__1r7rkhg{color:var(--__hashed_var__1jqb1tb)}", 3000);
+        _inject(".__hashed_var__1r7rkhg{color:var(--__hashed_var__1jqb1tb)}", 3000);
         "__hashed_var__1r7rkhg";"
       `);
       expect(transformation.metadata.stylex).toMatchInlineSnapshot(`