Fix: Allow references to object constants in ESLint plugin (#141)

facebook · Dec 12, 2023 · ca1dc8b · ca1dc8b
1 parent 31bc58c
commit ca1dc8b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/eslint-plugin/__tests__/stylex-valid-styles-test.js b/packages/eslint-plugin/__tests__/stylex-valid-styles-test.js
@@ -359,6 +359,18 @@ eslintTester.run('stylex-valid-styles', rule.default, {
     `,
   ],
   invalid: [
+    {
+      code: `
+        import stylex from 'stylex';
+        const styles = {default: {width: '30pt'}};
+        stylex.create(styles);
+      `,
+      errors: [
+        {
+          message: 'Styles must be represented as JavaScript objects',
+        },
+      ],
+    },
     {
       code: "import stylex from 'stylex'; stylex.create({default: {textAlin: 'left'}});",
       errors: [

diff --git a/packages/eslint-plugin/src/stylex-valid-styles.js b/packages/eslint-plugin/src/stylex-valid-styles.js
@@ -2347,8 +2347,7 @@ const stylexValidStyles = {
         node &&
         node.type === 'CallExpression' &&
         isStylexCallee(node.callee) &&
-        node.arguments.length === 1 &&
-        node.arguments[0].type === 'ObjectExpression'
+        node.arguments.length === 1
       );
     }