chore: clean code

facebook · Jan 8, 2025 · 2a00aef · 2a00aef
1 parent d31965e
commit 2a00aef
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 59 deletions.
diff --git a/packages/babel-plugin/__tests__/stylex-transform-create-test.js b/packages/babel-plugin/__tests__/stylex-transform-create-test.js
@@ -15,35 +15,17 @@ const { transformSync } = require('@babel/core');
 const flowPlugin = require('@babel/plugin-syntax-flow');
 const stylexPlugin = require('../src/index');
 
-function transform(source, opts = {}) {
-  return transformSync(source, {
-    filename: opts.filename,
-    parserOpts: {
-      flow: 'all',
-    },
-    babelrc: false,
-    plugins: [
-      flowPlugin,
-      [
-        stylexPlugin,
-        {
-          runtimeInjection: true,
-          unstable_moduleResolution: { type: 'haste' },
-          ...opts,
-        },
-      ],
-    ],
-  }).code;
-}
+const defaultParserOpts = {
+  flow: 'all',
+};
 
-function transformTypescript(source, opts = {}) {
+function transform(source, opts = {}, parserOpts = defaultParserOpts) {
   return transformSync(source, {
     filename: opts.filename,
-    parserOpts: {
-      plugins: ['typescript'],
-    },
+    parserOpts,
     babelrc: false,
     plugins: [
+      flowPlugin,
       [
         stylexPlugin,
         {
@@ -1326,7 +1308,8 @@ describe('@stylexjs/babel-plugin', () => {
 
     test('typescript namespace transform', () => {
       expect(
-        transformTypescript(`
+        transform(
+          `
           import stylex from 'stylex';
           namespace A {
             export const styles = stylex.create({
@@ -1336,7 +1319,10 @@ describe('@stylexjs/babel-plugin', () => {
             })
           }
           stylex.props(A.styles);
-      `),
+      `,
+          {},
+          { plugins: ['typescript'] },
+        ),
       ).toMatchInlineSnapshot(`
         "import _inject from "@stylexjs/stylex/lib/stylex-inject";
         var _inject2 = _inject;

diff --git a/packages/babel-plugin/__tests__/stylex-transform-create-theme-test.js b/packages/babel-plugin/__tests__/stylex-transform-create-theme-test.js
@@ -25,23 +25,14 @@ const defaultOpts = {
 // test environment still.
 const rootDir = '/stylex/packages/';
 
-function transform(source, opts = defaultOpts) {
-  return transformSync(source, {
-    filename: opts.filename || '/stylex/packages/TestTheme.stylex.js',
-    parserOpts: {
-      flow: 'all',
-    },
-    babelrc: false,
-    plugins: [[stylexPlugin, { ...defaultOpts, ...opts }]],
-  }).code;
-}
+const defaultParserOpts = {
+  flow: 'all',
+};
 
-function transformTypescript(source, opts = {}) {
+function transform(source, opts = defaultOpts, parserOpts = defaultParserOpts) {
   return transformSync(source, {
     filename: opts.filename || '/stylex/packages/TestTheme.stylex.js',
-    parserOpts: {
-      plugins: ['typescript'],
-    },
+    parserOpts,
     babelrc: false,
     plugins: [[stylexPlugin, { ...defaultOpts, ...opts }]],
   }).code;
@@ -707,13 +698,17 @@ describe('@stylexjs/babel-plugin stylex.createTheme with literals', () => {
 
   describe('[transform] typescript namespace', () => {
     expect(
-      transformTypescript(`
+      transform(
+        `
         import stylex from 'stylex';
         namespace A  {
           export const buttonTheme = stylex.defineVars(${createTheme});
           export const buttonThemePositive = stylex.createTheme(buttonTheme, ${createThemeWithDifferentOrder});
         }  
-    `),
+    `,
+        {},
+        { plugins: ['typescript'] },
+      ),
     ).toMatchInlineSnapshot(`
       "import stylex from 'stylex';
       namespace A {

diff --git a/packages/babel-plugin/__tests__/stylex-transform-define-vars-test.js b/packages/babel-plugin/__tests__/stylex-transform-define-vars-test.js
@@ -21,32 +21,23 @@ const defaultOpts = {
   debug: false,
 };
 
+const defaultParserOpts = {
+  flow: 'all',
+};
+
 // NOTE: While `rootDir` is optional now, It is needed in the
 // test environment still.
 const rootDir = '/stylex/packages/';
 
-function transform(source, opts = defaultOpts) {
+function transform(source, opts = defaultOpts, parserOpts = defaultParserOpts) {
   return transformSync(source, {
     filename: opts.filename || '/stylex/packages/TestTheme.stylex.js',
-    parserOpts: {
-      flow: 'all',
-    },
+    parserOpts,
     babelrc: false,
     plugins: [[stylexPlugin, { ...defaultOpts, ...opts }]],
   });
 }
 
-function transformTypescript(source, opts = {}) {
-  return transformSync(source, {
-    filename: opts.filename || '/stylex/packages/TestTheme.stylex.js',
-    parserOpts: {
-      plugins: ['typescript'],
-    },
-    babelrc: false,
-    plugins: [[stylexPlugin, { ...defaultOpts, ...opts }]],
-  }).code;
-}
-
 describe('@stylexjs/babel-plugin', () => {
   describe('[transform] stylex.defineVars()', () => {
     test('transforms variables object', () => {
@@ -785,7 +776,7 @@ describe('@stylexjs/babel-plugin', () => {
 
     test('transform typescript namespace', () => {
       expect(
-        transformTypescript(
+        transform(
           `
          import stylex from 'stylex';
          namespace A {
@@ -797,7 +788,8 @@ describe('@stylexjs/babel-plugin', () => {
          }
       `,
           { dev: true, ...defaultOpts },
-        ),
+          { plugins: ['typescript'] },
+        ).code,
       ).toMatchInlineSnapshot(`
         "import _inject from "@stylexjs/stylex/lib/stylex-inject";
         var _inject2 = _inject;