Prevent race conditions in TimerManager #48519
Open
+76
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67888312 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 7, 2025
Summary:
When working on RN instance reload in D67818969 I noticed that we can crash in TimerManager when the RN instance is reloaded.
{F1974211648}
This change aims to fix it.
NOTE: `TimerManager` is a shared_ptr
React Native Granite
https://www.internalfb.com/code/fbsource/[46cacd0162d251cfcd08f069f20eaec600f59c7f]/xplat/ReactNative/react-native-cxx/react/runtime/ReactHost.cpp?lines=119-120
React Native iOS / Android
https://www.internalfb.com/code/search?q=-filepath%3ATimerManager.h%7CTimerManager.cpp%20filepath%3Areact-native-github%20case%3Ayes%20repo%3Afbsource%20TimerManager&lang_filter=cpp%2Cobjective-cpp
Differential Revision: D67888312
christophpurrer
force-pushed
the
export-D67888312
branch
from
045c602 to
ddae982
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888312 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 7, 2025
Summary:
When working on RN instance reload in D67818969 I noticed that we can crash in TimerManager when the RN instance is reloaded.
{F1974211648}
This change aims to fix it.
NOTE: `TimerManager` is a shared_ptr
React Native Granite
https://www.internalfb.com/code/fbsource/[46cacd0162d251cfcd08f069f20eaec600f59c7f]/xplat/ReactNative/react-native-cxx/react/runtime/ReactHost.cpp?lines=119-120
React Native iOS / Android
https://www.internalfb.com/code/search?q=-filepath%3ATimerManager.h%7CTimerManager.cpp%20filepath%3Areact-native-github%20case%3Ayes%20repo%3Afbsource%20TimerManager&lang_filter=cpp%2Cobjective-cpp
Differential Revision: D67888312
christophpurrer
force-pushed
the
export-D67888312
branch
from
ddae982 to
f0d9e64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888312 |
Summary:
When working on RN instance reload in D67818969 I noticed that we can crash in TimerManager when the RN instance is reloaded.
{F1974211648}
This change aims to fix it.
NOTE: `TimerManager` is a shared_ptr
React Native Granite
https://www.internalfb.com/code/fbsource/[46cacd0162d251cfcd08f069f20eaec600f59c7f]/xplat/ReactNative/react-native-cxx/react/runtime/ReactHost.cpp?lines=119-120
React Native iOS / Android
https://www.internalfb.com/code/search?q=-filepath%3ATimerManager.h%7CTimerManager.cpp%20filepath%3Areact-native-github%20case%3Ayes%20repo%3Afbsource%20TimerManager&lang_filter=cpp%2Cobjective-cpp
Differential Revision: D67888312
christophpurrer
force-pushed
the
export-D67888312
branch
from
f0d9e64 to
f04db61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When working on RN instance reload in D67818969 I noticed that we can crash in TimerManager when the RN instance is reloaded.
{F1974211648}
This change aims to fix it.
NOTE:
TimerManageris a shared_ptrReact Native Granite
https://www.internalfb.com/code/fbsource/[46cacd0162d251cfcd08f069f20eaec600f59c7f]/xplat/ReactNative/react-native-cxx/react/runtime/ReactHost.cpp?lines=119-120
React Native iOS / Android
https://www.internalfb.com/code/search?q=-filepath%3ATimerManager.h%7CTimerManager.cpp%20filepath%3Areact-native-github%20case%3Ayes%20repo%3Afbsource%20TimerManager&lang_filter=cpp%2Cobjective-cpp
Differential Revision: D67888312