Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SurfaceRegistryBinding to AppRegistryBinding #48337

Closed
wants to merge 3 commits into from

Conversation

javache
Copy link
Member

@javache javache commented Dec 19, 2024

Summary:
SurfaceRegistryBinding refers to a forked SurfaceRegistry we had for a while in bridgeless but which was merged back into AppRegistry. Align the native name as well to make it explicit that all this class does is call into AppRegistry.

Changelog: [Internal]

Differential Revision: D67342499

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67342499

javache added a commit to javache/react-native that referenced this pull request Dec 19, 2024
Summary:
Pull Request resolved: facebook#48337

`SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`.

Changelog: [Internal]

Differential Revision: D67342499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67342499

Differential Revision: D67342500
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67342499

javache added a commit to javache/react-native that referenced this pull request Jan 7, 2025
Summary:
Pull Request resolved: facebook#48337

`SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D67342499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67342499

javache added a commit to javache/react-native that referenced this pull request Jan 7, 2025
Summary:
Pull Request resolved: facebook#48337

`SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D67342499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67342499

javache added a commit to javache/react-native that referenced this pull request Jan 7, 2025
Summary:
Pull Request resolved: facebook#48337

`SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D67342499
Summary:
Pull Request resolved: facebook#48337

`SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D67342499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67342499

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in afd77d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants