-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SurfaceRegistryBinding to AppRegistryBinding #48337
Conversation
This pull request was exported from Phabricator. Differential Revision: D67342499 |
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Differential Revision: D67342499
087a1ca
to
207483d
Compare
This pull request was exported from Phabricator. Differential Revision: D67342499 |
Differential Revision: D67342500
Differential Revision: D67342498
This pull request was exported from Phabricator. Differential Revision: D67342499 |
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
207483d
to
f603349
Compare
This pull request was exported from Phabricator. Differential Revision: D67342499 |
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
f603349
to
b8b102a
Compare
This pull request was exported from Phabricator. Differential Revision: D67342499 |
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
b8b102a
to
3eb2b01
Compare
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
This pull request was exported from Phabricator. Differential Revision: D67342499 |
3eb2b01
to
3cf3ee2
Compare
This pull request has been merged in afd77d5. |
Summary:
SurfaceRegistryBinding
refers to a forkedSurfaceRegistry
we had for a while in bridgeless but which was merged back intoAppRegistry
. Align the native name as well to make it explicit that all this class does is call intoAppRegistry
.Changelog: [Internal]
Differential Revision: D67342499