Revert D67868219 (#48512)

Summary: Pull Request resolved: #48512 This diff reverts D67868219 Breaking OTA Compatibility Check https://fburl.com/onedetection/m0hqsvjp [General][Changed] - Revert: Mark intersectionRect required in NativeIntersectionObserverEntry to reflect native logic. Reviewed By: lunaleaps Differential Revision: D67882016 fbshipit-source-id: 8cff299ee823f8ef06fe96667e832b68be45666d
facebook · Jan 7, 2025 · cd40e4e · cd40e4e
1 parent 65c6a0a
commit cd40e4e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...t-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h b/...t-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h
@@ -45,7 +45,7 @@ using NativeIntersectionObserverEntry =
         // rootRect
         RectAsTuple,
         // intersectionRect
-        RectAsTuple,
+        std::optional<RectAsTuple>,
         // isIntersectingAboveThresholds
         bool,
         // time

diff --git a/...react-native/src/private/webapis/intersectionobserver/specs/NativeIntersectionObserver.js b/...react-native/src/private/webapis/intersectionobserver/specs/NativeIntersectionObserver.js
@@ -17,7 +17,8 @@ export type NativeIntersectionObserverEntry = {
   targetInstanceHandle: mixed,
   targetRect: $ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
   rootRect: $ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
-  intersectionRect: $ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
+  // TODO(T209328432) - Remove optionality of intersectionRect when native changes are released
+  intersectionRect: ?$ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
   isIntersectingAboveThresholds: boolean,
   time: number,
 };