Merge pull request #169 from spicyj/cr-rel

Add files for Chrome and Firefox releases
facebook · Sep 2, 2015 · 0fcdeb9 · 0fcdeb9
2 parents 3d8545d + 04123e6
commit 0fcdeb9
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 8 deletions.
diff --git a/shells/chrome/icons/icon128.png b/shells/chrome/icons/icon128.png
diff --git a/shells/chrome/icons/icon48.png b/shells/chrome/icons/icon48.png
diff --git a/shells/chrome/manifest.json b/shells/chrome/manifest.json
@@ -1,9 +1,11 @@
 {
   "manifest_version": 2,
-  "name": "New React Developer Tools",
+  "name": "React Developer Tools",
   "description": "Adds React debugging tools to the Chrome Developer Tools.",
   "version": "0.14",
   "icons": {
+    "48": "icons/icon48.png",
+    "128": "icons/icon128.png"
   },
 
   "devtools_page": "main.html",
@@ -18,8 +20,7 @@
 
   "permissions": [
     "http://*/",
-    "https://*/*",
-    "file://*"
+    "https://*/*"
   ],
 
   "content_scripts": [

diff --git a/shells/chrome/webpack.backend.js b/shells/chrome/webpack.backend.js
@@ -11,8 +11,10 @@
 
 var webpack = require('webpack');
 
+var __DEV__ = process.env.NODE_ENV !== 'production';
+
 module.exports = {
-  devtool: 'cheap-module-eval-source-map',
+  devtool: __DEV__ ? 'cheap-module-eval-source-map' : false,
   entry: {
     backend: './src/backend.js',
   },

diff --git a/shells/chrome/webpack.config.js b/shells/chrome/webpack.config.js
@@ -9,8 +9,10 @@
  */
 'use strict';
 
+var __DEV__ = process.env.NODE_ENV !== 'production';
+
 module.exports = {
-  devtool: 'cheap-module-eval-source-map',
+  devtool: __DEV__ ? 'cheap-module-eval-source-map' : false,
   entry: {
     main: './src/main.js',
     background: './src/background.js',

diff --git a/shells/firefox/.jpmignore b/shells/firefox/.jpmignore
@@ -2,3 +2,4 @@
 *.swo
 .DS_Store
 node_modules
+src
diff --git a/shells/firefox/data/icon.png b/shells/firefox/data/icon.png
diff --git a/shells/firefox/data/tool-react.png b/shells/firefox/data/tool-react.png
diff --git a/shells/firefox/main/ReactPanel.js b/shells/firefox/main/ReactPanel.js
@@ -19,7 +19,7 @@ const ReactPanel = Class({
   extends: Panel,
   label: 'React',
   tooltip: 'Debug & Develop React Apps',
-  icon: './icon.png',
+  icon: './tool-react.png',
   url: './panel.html',
   setup(options) {
     // this.debuggee = options.debuggee;

diff --git a/shells/firefox/package.json b/shells/firefox/package.json
@@ -1,8 +1,8 @@
 {
   "title": "React Devtools",
   "name": "react-devtools",
-  "version": "0.0.1",
-  "description": "Extend the devtools to help you debug and develop react apps",
+  "version": "0.14.1",
+  "description": "Adds React debugging tools to Firefox.",
   "main": "main/index.js",
   "author": "Facebook",
   "engines": {
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,3 +2,4 @@ @@
     *.swo
     .DS_Store
     node_modules
+    src