Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.3.2 #2861

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Release 3.3.2 #2861

merged 13 commits into from
Jan 22, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 21, 2025 •
edited by vahidkay-meta
Loading

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments. 
    git fetch origin release/3.3.2
git checkout release/3.3.2
  4. Simulate the release locally 
    woorelease simulate --product_version=3.3.2  --wp_tested=6.7 --wc_tested=9.6 --generate_changelog https://github.com/facebook/facebook-for-woocommerce/tree/release/3.3.2
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  5. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  6. Automated tests are passing.
  7. Test the package
    1. Install the /tmp/facebook-for-woocommerce.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release 
    woorelease release --product_version=3.3.2  --wp_tested=6.7 --wc_tested=9.6  --generate_changelog https://github.com/facebook/facebook-for-woocommerce/tree/release/3.3.2
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/facebook/facebook-for-woocommerce/releases/3.3.2, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (PR), if applicable for this repo.
  5. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  6. Mark related ideas complete on the feature requests page.

After deploy

  1. Confirm the release deployed correctly to WPORG.
    • Ensure you can download and install the latest release from WPORG and WCCOM.
    • We've had an issue where the release tag (e.g. 2.6.1) wasn't present in the svn tags/ folder.
    • Troubleshooting processes when the release version doesn't exist in the svn tags/ folder:
      1. Check the version by Stable tag in https://plugins.svn.wordpress.org/facebook-for-woocommerce/trunk/readme.txt to see if the new release is committed to trunk
      2. If the above version is the same as the one just released, then you can make up the missed version tag by svn cp https://plugins.svn.wordpress.org/facebook-for-woocommerce/trunk https://plugins.svn.wordpress.org/facebook-for-woocommerce/tags/X.X.X -m "Tagging version X.X.X". Please note that the X.X.X is used as a placeholder but should be replaced with the actual release version (e.g., 1.5.0).
      3. Wait for a while, and the zip file should be able to download from: https://downloads.wordpress.org/plugin/facebook-for-woocommerce.x.x.x.zip
  2. Close the release milestone.
  3. Publish any documentation updates relating to the release:

halilozanakgul and others added 8 commits January 21, 2025 16:16
@halilozanakgul
Update php-unit-tests.yml to install SVN (#2859)
6530a5a
@vinkmeta
Fix: get_global_unique_id function compatibility check (#2856)
76f0a2e 
Summary:
Fixed a bug that arose from our reliance on the plugin version compatibility tag for the public function get_global_unique_id. This function was actually introduced in WooCommerce version 9.2, but was incorrectly tagged as being available from version 9.1 onwards.
To ensure correct functionality, we have replaced the use of Compatibility::is_wc_version_gte() with method_exists(), which checks for the availability of specific public methods rather than relying on version numbers

Differential Revision: D68424348
@devbodaghe @mshymon
Update catalog link to navigate to correct tab in Commerce Manager (#…
62f93a6 
…2848)

* Update catalog link to navigate to correct tab in Commerce Manager

Co-authored-by: Marian Shymon <[email protected]>

---------

Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
@vinkmeta
Fixed product url links (#2852)
0072f1c
@mshymon @halilozanakgul
Fix - Removed the "Sell on Instagram" checkbox from UX and cleaned up…
48d739a 
… the backend (#2854)

* Removed the  Sell on Instagram UX and cleane dup the backend.

* Update php-unit-tests.yml to install SVN (#2859)

---------

Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Halil Ozan Akgül <[email protected]>
@devbodaghe
feat: Add custom fields to product data structure (#2836)
5c7cef9 
* feat: Add custom fields to product data structure

---------

Co-authored-by: David Evbodaghe <[email protected]>
@vinkmeta
Fixed Category specific attributes related issues (#2860)
00f5ff1
@github-actions
Start release/3.3.2.
78d9888
@vahidkay-meta vahidkay-meta merged commit d9df5cd into trunk Jan 22, 2025
5 checks passed
@vahidkay-meta vahidkay-meta deleted the release/3.3.2 branch January 22, 2025 08:19
vahidkay-meta added a commit that referenced this pull request Jan 23, 2025
@vahidkay-meta @github-actions
@halilozanakgul @vinkmeta @devbodaghe @mshymon
Merging Trunk into Develop branch (#2850)
d0afc3f 
* Start `release/3.3.1`.

* Updated the version number to 3.3.1

* Release 3.3.2 (#2861)

* Update php-unit-tests.yml to install SVN (#2859)

* Fix: get_global_unique_id function compatibility check (#2856)

Summary:
Fixed a bug that arose from our reliance on the plugin version compatibility tag for the public function get_global_unique_id. This function was actually introduced in WooCommerce version 9.2, but was incorrectly tagged as being available from version 9.1 onwards.
To ensure correct functionality, we have replaced the use of Compatibility::is_wc_version_gte() with method_exists(), which checks for the availability of specific public methods rather than relying on version numbers

Differential Revision: D68424348

* Update catalog link to navigate to correct tab in Commerce Manager (#2848)

* Update catalog link to navigate to correct tab in Commerce Manager

Co-authored-by: Marian Shymon <[email protected]>

---------

Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>

* Fixed product url links (#2852)

* Fix - Removed the  "Sell on Instagram" checkbox from UX and cleaned up the backend (#2854)

* Removed the  Sell on Instagram UX and cleane dup the backend.

* Update php-unit-tests.yml to install SVN (#2859)

---------

Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Halil Ozan Akgül <[email protected]>

* feat: Add custom fields to product data structure (#2836)

* feat: Add custom fields to product data structure

---------

Co-authored-by: David Evbodaghe <[email protected]>

* Fixed Category specific attributes related issues (#2860)

* Start `release/3.3.2`.

* updated the changelog and stable version

* Updated the current version

* Updated the WC supported version to 9.6

* Updated the stable version

---------

Co-authored-by: Halil Ozan Akgül <[email protected]>
Co-authored-by: vinkmeta <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vahid Kaykhaei <[email protected]>
Co-authored-by: vahidkay-meta <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Halil Ozan Akgül <[email protected]>
Co-authored-by: vinkmeta <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
atuld123 pushed a commit that referenced this pull request Feb 1, 2025
@vahidkay-meta @github-actions
@halilozanakgul @vinkmeta @devbodaghe @mshymon
Merging Trunk into Develop branch (#2850)
2cbae79 
* Start `release/3.3.1`.

* Updated the version number to 3.3.1

* Release 3.3.2 (#2861)

* Update php-unit-tests.yml to install SVN (#2859)

* Fix: get_global_unique_id function compatibility check (#2856)

Summary:
Fixed a bug that arose from our reliance on the plugin version compatibility tag for the public function get_global_unique_id. This function was actually introduced in WooCommerce version 9.2, but was incorrectly tagged as being available from version 9.1 onwards.
To ensure correct functionality, we have replaced the use of Compatibility::is_wc_version_gte() with method_exists(), which checks for the availability of specific public methods rather than relying on version numbers

Differential Revision: D68424348

* Update catalog link to navigate to correct tab in Commerce Manager (#2848)

* Update catalog link to navigate to correct tab in Commerce Manager

Co-authored-by: Marian Shymon <[email protected]>

---------

Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>

* Fixed product url links (#2852)

* Fix - Removed the  "Sell on Instagram" checkbox from UX and cleaned up the backend (#2854)

* Removed the  Sell on Instagram UX and cleane dup the backend.

* Update php-unit-tests.yml to install SVN (#2859)

---------

Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Halil Ozan Akgül <[email protected]>

* feat: Add custom fields to product data structure (#2836)

* feat: Add custom fields to product data structure

---------

Co-authored-by: David Evbodaghe <[email protected]>

* Fixed Category specific attributes related issues (#2860)

* Start `release/3.3.2`.

* updated the changelog and stable version

* Updated the current version

* Updated the WC supported version to 9.6

* Updated the stable version

---------

Co-authored-by: Halil Ozan Akgül <[email protected]>
Co-authored-by: vinkmeta <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vahid Kaykhaei <[email protected]>
Co-authored-by: vahidkay-meta <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Halil Ozan Akgül <[email protected]>
Co-authored-by: vinkmeta <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@facebook-github-bot @vahidkay-meta @halilozanakgul @vinkmeta @devbodaghe @mshymon