-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration label and tooltip cleanup #2815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the labels open proper documentation sections. Custom Image URL behaves correctly for Simple and Variable products when not in Block Product Editor. Looks good! Thank you, @layoutd ! |
message-dimke
approved these changes
Oct 31, 2024
Thanks @message-dimke! I forgot to mention that I centered the Disconnect link vertically, very trivial but I think it's much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR revises some fields labels related to Facebook Sync, adds a few tooltips, and adds links to more information at the bottom of Advertise, Product sync, and in the Debug section options.
Pending is adding a documentation link at the bottom of Product Sets, but would probably need some DOM element manipulation with JS, so leaving that one for a different PR.
It also clears up some Product Editor form issues where the Custom Image URL field was always displayed initially, and makes the field contingent on the "Use custom image" option being selected.
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Screenshots:
Detailed test instructions:
Changelog entry