Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration label and tooltip cleanup #2815

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Conversation

layoutd
Copy link
Contributor

@layoutd layoutd commented Oct 26, 2024

Changes proposed in this Pull Request:

This PR revises some fields labels related to Facebook Sync, adds a few tooltips, and adds links to more information at the bottom of Advertise, Product sync, and in the Debug section options.

Pending is adding a documentation link at the bottom of Product Sets, but would probably need some DOM element manipulation with JS, so leaving that one for a different PR.

It also clears up some Product Editor form issues where the Custom Image URL field was always displayed initially, and makes the field contingent on the "Use custom image" option being selected.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Screenshots:

image

image

image

image

Detailed test instructions:

  1. Check that all learn more links work correctly.
  2. Check text of learn more links and tooltips.
  3. Confirm that the Custom Image URL field works correctly (displays and hides, saves, etc) on Simple and Variable products.

Changelog entry

Tweak - Tooltips, config labels, documentation links.

@layoutd layoutd self-assigned this Oct 26, 2024
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Oct 26, 2024
@layoutd layoutd added changelog: tweak Small change, that isn't actually very important. and removed changelog: update Big changes to something that wasn't broken. labels Oct 29, 2024
@layoutd layoutd marked this pull request as ready for review October 29, 2024 15:55
@layoutd layoutd requested a review from a team October 29, 2024 15:55
@message-dimke message-dimke requested review from message-dimke and removed request for a team October 31, 2024 12:58
@message-dimke
Copy link
Contributor

All the labels open proper documentation sections. Custom Image URL behaves correctly for Simple and Variable products when not in Block Product Editor.

Looks good! Thank you, @layoutd !

@layoutd
Copy link
Contributor Author

layoutd commented Oct 31, 2024

Thanks @message-dimke!

I forgot to mention that I centered the Disconnect link vertically, very trivial but I think it's much better

Before
image

After
image

@layoutd layoutd merged commit 9ba32ec into develop Oct 31, 2024
4 checks passed
@layoutd layoutd deleted the update/config-tooltips branch October 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants