perf(theme): use SVG sprite for IconExternalLink #10885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: performance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -178 kB (-1.59%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -181 kB (-1.55%) Total Size: 11.5 MB
ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
<ExternalLink>icon is widely used in our theme layout elements:Using SVG-in-JSX leads to the SVG being inlined/duplicated multiple times in the static HTML output.
Let's try to use SVG sprites instead.
See:
Test Plan
CI + Argos
Test links
https://deploy-preview-10885--docusaurus-2.netlify.app/