Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Log browser commands #7

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
## [Unreleased](https://github.com/rubycdp/ferrum/compare/v0.12...main) ##
## [Unreleased](https://github.com/rubycdp/ferrum/compare/v0.13...main) ##

### Added

### Changed

### Fixed

### Removed

## [0.13](https://github.com/rubycdp/ferrum/compare/v0.12...v0.13) - (Nov 12, 2022) ##

### Added

Expand Down
19 changes: 19 additions & 0 deletions lib/ferrum/browser/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,31 @@ def command(method, params = {})
data = pending.value!(@connectable.timeout)
@pendings.delete(message[:id])

log_command(method, message, data, @pendings) if ENV["LOG_ALL_FERRUM_COMMANDS"]
raise DeadBrowserError if data.nil? && @ws.messages.closed?
raise TimeoutError unless data

error, response = data.values_at("error", "result")
raise_browser_error(error) if error
response
rescue DeadBrowserError, TimeoutError => error
log_command(method, message, data, @pendings, error)
raise error
end

def log_command(method, message, data, pendings, error = nil)
puts "-----"
if error
puts "#{self.class.name} - ERROR #{error}"
else
puts "#{self.class.name} - SUCCESS"
end

puts "method: #{method}"
puts "message: #{message}"
puts "data: #{data}"
puts "pendings: #{pendings}"
puts "-----"
end

def on(event, &block)
Expand Down