Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSX] Hack to allow plugins to specify a property is to be spread rather than constructed as a key,value pair #4038

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[JSX] Hack to allow plugins to specify a property is to be spread rather than constructed as a key,value pair #4038

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c07c18b
Enhancement - special property name for plugins to utilise and spread…
shayanhabibi Feb 8, 2025
e7111a6
Magic attribute key `__SPREAD_PROPERTY__` to spread objects in JSX el…
shayanhabibi Feb 8, 2025
1633c5d
Add __BOOL_PROPERTY__ magic attribute for JSX elements
shayanhabibi Feb 9, 2025
f12f3da
Add tests for magic properties
shayanhabibi Feb 9, 2025
5ddc11a
Merge remote-tracking branch 'original/main' into spreader
shayanhabibi Feb 10, 2025
862d2ce
Pass attrs of JSX Els further down AST transformations
shayanhabibi Feb 10, 2025
66421cd
Revert "Pass attrs of JSX Els further down AST transformations"
shayanhabibi Feb 10, 2025
b6da4fa
Revert "Add __BOOL_PROPERTY__ magic attribute for JSX elements"
shayanhabibi Feb 10, 2025
1846624
Remove __BOOL_PROP__ magic
shayanhabibi Feb 10, 2025
dcb0c8d
null prop key will only render value
shayanhabibi Mar 5, 2025
420a534
Revert "Add tests for magic properties"
shayanhabibi Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Fable.Transforms/BabelPrinter.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ module PrinterExtensions =
function
| _, NullOrUndefinedOrVoid -> ()
| key, StringConstant value -> printProp (fun () -> printer.Print($"{key}=\"{value}\""))
| "", value -> printProp (fun () -> printer.Print(value))
| key, value ->
printProp (fun () ->
printer.Print(key + "={")
Expand Down
Loading