-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep comments for ts interface generation ✨ #4020
Keep comments for ts interface generation ✨ #4020
Conversation
@Freymaurer Can you also please update the changelog (both in Fable.Cli and Fable.Compiler) with this PR? Thanks! |
Is there some contribution guide i can follow or just try to follow the existing patterns? |
Just try to follow the existing convention for this PR it would be something like: * [TS] Include XML Doc comment on interface properties (by @Freymaurer) |
@ncave done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9e62915
to
45a1ec5
Compare
8966af1
to
a06e807
Compare
cfc3426
into
fable-compiler:feature/emit_interface_paramObject
Thank you |
…tern * [TS] Emit `interface` declaration when encountering a `ParamObject` pattern * Try fix condition * Forward generics information * Keep comments for ts interface generation ✨ (#4020) * Keep comments for ts interface generation ✨ * Update QuickTest.fs, fix typo * Update changelog and rmv print statements * Generate the correct type name when assigning a `ParamObject` to a variable * Add support for inheritance and multi shaped ParamObject * Update changelog entry * Revert `QuickTest.fs` --------- Co-authored-by: Kevin Frey <[email protected]>
I updated ts interface generation to keep xmlDoc comments from f# code. I tried to uphold existing patterns, but please check if everything is fine with you:
The changes transpile the following f# code:
to:
I kept the example in
src/quicktest/QuickTest.fs
.