[All] Disable .NET Welcome message when cracking project

fable-compiler · Jan 23, 2025 · 016e1c3 · 016e1c3
1 parent d4541ba
commit 016e1c3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/src/Fable.Cli/CHANGELOG.md b/src/Fable.Cli/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 5.0.0-alpha.7 - 2025-01-23
+
+### Fixed
+
+* [All] Disable .NET Welcome message when cracking project (#4014) (by @MangelMaxime)
+
 ## 5.0.0-alpha.6 - 2025-01-23
 
 ### Added

diff --git a/src/Fable.Compiler/CHANGELOG.md b/src/Fable.Compiler/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 5.0.0-alpha.7 - 2025-01-23
+
+### Fixed
+
+* [All] Disable .NET Welcome message when cracking project (#4014) (by @MangelMaxime)
+
 ## 5.0.0-alpha.6 - 2025-01-23
 
 ### Added

diff --git a/src/Fable.Compiler/MSBuildCrackerResolver.fs b/src/Fable.Compiler/MSBuildCrackerResolver.fs
@@ -31,14 +31,16 @@ module private MSBuildCrackerResolver =
     let private dotnet_msbuild_with_defines (fsproj: FullPath) (args: string) (defines: string list) : Async<string> =
         backgroundTask {
             let psi = ProcessStartInfo "dotnet"
-            let pwd = Assembly.GetEntryAssembly().Location |> Path.GetDirectoryName
 
             psi.WorkingDirectory <- Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)
 
             psi.Arguments <- $"msbuild \"%s{fsproj}\" %s{args}"
             psi.RedirectStandardOutput <- true
             psi.RedirectStandardError <- true
             psi.UseShellExecute <- false
+            // Disable Dotnet Welcome message
+            // https://github.com/fable-compiler/Fable/issues/4014
+            psi.Environment.Add("DOTNET_NOLOGO", "1")
 
             if not (List.isEmpty defines) then
                 let definesValue = defines |> String.concat ";"
@@ -52,10 +54,9 @@ module private MSBuildCrackerResolver =
             do! ps.WaitForExitAsync()
 
             let fullCommand = $"dotnet msbuild %s{fsproj} %s{args}"
-            // printfn "%s" fullCommand
 
             if not (String.IsNullOrWhiteSpace error) then
-                failwithf $"In %s{pwd}:\n%s{fullCommand}\nfailed with\n%s{error}"
+                failwithf $"In %s{psi.WorkingDirectory}:\n%s{fullCommand}\nfailed with\n%s{error}"
 
             return output.Trim()
         }