Mark Construct nogil so it can operate in parallel #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this doesn't meaningfully change the total runtime for my use, there's still a lot of overhead from the marshalling. |
|
Magenta is the Construct time (~150mS); it's dwarfed by the readback and classification [point-in-polygon] of vertices in my code but every little bit helps. |
fabanc
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the values are already marshalled to C++ structures, this should be safe to drop the GIL. More methods could be added to this as well but I feel there's some upcoming refactor for #31/#32 that I'd let shake out first.