Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Improvement - Remove use of inputPoints and inputSegments in pyvoronoi.pyx #32

Open
fabanc opened this issue Mar 18, 2024 · 0 comments
Assignees

Comments

@fabanc
Copy link
Owner

fabanc commented Mar 18, 2024

Those variables duplicated this information duplicate the vector information that is already stored in the C++ class VoronoiDiagram in voronoi.hpp. This information is already contained in the private attributes points and segments

class VoronoiDiagram {
public:
	VoronoiDiagram();
	void AddPoint(Point p);
	void AddSegment(Segment s);
	void Construct();

       // ...

private:
	std::vector<Point> points;
	std::vector<Segment> segments;
	voronoi_diagram<double> vd;

};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant