Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap same-date fix #411

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Conversation

Naitsabot
Copy link
Contributor

@Naitsabot Naitsabot commented Mar 1, 2024

Fixes #398
Lidt hacky

Ran 164 tests in 18.158s

OK
Destroying test database for alias 'default'...

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (397730a) to head (531400a).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #411   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files          33       33           
  Lines        4548     4553    +5     
  Branches      267      267           
=======================================
+ Hits         2431     2434    +3     
- Misses       2067     2069    +2     
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Naitsabot and others added 2 commits March 1, 2024 10:47
fix accidental formatting from when debugging
Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would've been awesome to have a test implemented to prevent this type of bug in the future. Otherwise, clever fix

@krestenlaust krestenlaust merged commit 39b7b1b into f-klubben:next Mar 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heatmap doesn't show 'today'
2 participants