-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature MobilePay transaction integration #204
Feature MobilePay transaction integration #204
Conversation
Expected human lock library. 10/10 disappoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing. I have not test run the code :'(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God ide at få dette lavet. @DelusionalLogic og jeg havde tidligere tænkt på at lave det samme, men ifølge daværende formand kunne man ende i problemer hvis ikke der var en person i loop'et. Denne løsning har ikke samme problem, så go for it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel better living in a world where this code is inside the stregsystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to have implemented logging, though I think this maybe should've been its own PR, yet all other comments I have are minor things.
Good job, with everything! 👍 :)
Co-authored-by: Asger Geel Weirsøe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## next #204 +/- ##
==========================================
- Coverage 82.85% 82.39% -0.46%
==========================================
Files 30 30
Lines 2006 2244 +238
Branches 135 157 +22
==========================================
+ Hits 1662 1849 +187
- Misses 321 370 +49
- Partials 23 25 +2
Continue to review full report at Codecov.
|
VippsMobilepay-fusion's new API might have opened up for automatic matching without having to write information in the comment-feature on transactions. The last 4-digits and legal name of payer is received. #416 Documents implementation of this new API. |
Processing payments as a Treo can be frustrating as you're referencing two lists; payments on stregsystemet and transactions from MobilePay. Sometimes Treos do payments in reverse order, making it harder to figure out which transactions are processed and which are missing. Sometimes multiple Treos are making them concurrently and I unfortunately haven't found a human lock library for Python.
Maybe this can be fully automated for 'correct' MobilePay-comments in the future when the MobilePay Transactions API has been set up. This has also been discussed in #203.
Meanwhile, MobilePay offers functionality to download a CSV containing the same information. This PR adds functionality to upload, parse, and create
MobilePayment
objects automatically for these transactions along with a utility for processing these transactions, creating ordinaryPayments
when approved by a Treo.Thanks @joandrsn for figuring out MobilePay API import 👌