Fix EZP-23908: expiry.php race condition

Restore timestamps before saving, to reduce chance of race condition issues Simplified redundant code Removed unneeded parenthesis
ezsystems · Jan 26, 2015 · aca99a1 · aca99a1
1 parent 1621d93
commit aca99a1
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/lib/ezutils/classes/ezexpiryhandler.php b/lib/ezutils/classes/ezexpiryhandler.php
@@ -61,6 +61,24 @@ static function fetchData( $path )
      */
     function store()
     {
+        if ( !$this->IsModified )
+        {
+            return;
+        }
+
+        // EZP-23908: Restore timestamps before saving, to reduce chance of race condition issues
+        $modifiedTimestamps = $this->Timestamps;
+        $this->restore();
+
+        // Apply timestamps that have been added or modified in this process
+        foreach ( $modifiedTimestamps as $name => $value )
+        {
+            if ( $value > self::getTimestamp( $name, 0 ) )
+            {
+                $this->setTimestamp( $name, $value );
+            }
+        }
+
         if ( $this->IsModified )
         {
             $this->CacheFile->storeContents( "<?php\n\$Timestamps = " . var_export( $this->Timestamps, true ) . ";\n?>", 'expirycache', false, true );