[TASK] Replace EventInterfaces by specific Events #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the used EventInterfaces by the really used specific Events in the `__invoke()` method of Events where it's suitable. In the next step the superfluous interfaces can be removed. Furthermore can the `Services.yaml` be shortened by using the #AsEventListener attribute.
|
This is step 1/3 of the proposal. If it okay I would continue with the other steps. |
extcode
approved these changes
Oct 6, 2024
|
@rintisch I think this step is OK. But I would keep the interface as a contract so that developers who use the event know what they can rely on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the used EventInterfaces by the
really used specific Events in the
__invoke()method of Events where it's suitable.
In the next step the superfluous interfaces can
be removed. Furthermore can the
Services.yamlbe shortened by using the #AsEventListener
attribute.