-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Rename build folders #543
Conversation
/Build/ export-ignore | ||
/build/ export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the intention of the renaming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried typo3/tailor yesterday and found that the extension excludes the build folder by default, but not with a capital first letter.
I would like to follow this guideline here. Sooner or later I will also put my own configuration file into the repo to avoid unnecessary files ending up in the TER.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know. Thanks for the background information!
I am only wondering now whether it is okay to exclude the source JS Files? Maybe someone wants to include them in an own build process? But that might be a seldom edge case. Someone who wants to do such advanced stuff might not use legacy installation anyway...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I‘m not a developer often build frontend javascript. Perhaps we should move the TypeScript to another folder. What‘s about Resources/Private/JavaScript ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be okay. That's how https://github.com/jweiland-net/maps2/tree/main/Resources/Private/Build/JavaScript does it.
f5e466c
to
2b9ed4e
Compare
For another topic I had a look at EXT:tea and EXT:blog_example (both being best practice examples) but none of them uses small case for the https://github.com/TYPO3-Documentation/blog_example/tree/main/Build https://github.com/FriendsOfTYPO3/tea/tree/main/Build So I am wondering whether it's really good to use small case. 🤔 |
No description provided.