Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Rename build folders #543

Closed
wants to merge 6 commits into from
Closed

[CLEANUP] Rename build folders #543

wants to merge 6 commits into from

Conversation

extcode
Copy link
Owner

@extcode extcode commented Jun 20, 2024

No description provided.

@extcode extcode self-assigned this Jun 20, 2024
composer.json Show resolved Hide resolved
/Build/ export-ignore
/build/ export-ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intention of the renaming?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried typo3/tailor yesterday and found that the extension excludes the build folder by default, but not with a capital first letter.
I would like to follow this guideline here. Sooner or later I will also put my own configuration file into the repo to avoid unnecessary files ending up in the TER.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks for the background information!
I am only wondering now whether it is okay to exclude the source JS Files? Maybe someone wants to include them in an own build process? But that might be a seldom edge case. Someone who wants to do such advanced stuff might not use legacy installation anyway...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I‘m not a developer often build frontend javascript. Perhaps we should move the TypeScript to another folder. What‘s about Resources/Private/JavaScript ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@extcode extcode force-pushed the rename_build_folders branch from f5e466c to 2b9ed4e Compare June 21, 2024 14:31
@extcode extcode changed the title Rename build folders [CLEANUP] Rename build folders Jun 21, 2024
@rintisch
Copy link
Collaborator

For another topic I had a look at EXT:tea and EXT:blog_example (both being best practice examples) but none of them uses small case for the Build folder.

https://github.com/TYPO3-Documentation/blog_example/tree/main/Build

https://github.com/FriendsOfTYPO3/tea/tree/main/Build

So I am wondering whether it's really good to use small case. 🤔

@extcode extcode closed this Oct 24, 2024
@extcode extcode deleted the rename_build_folders branch October 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants