Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Change rector configuration and run #531

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

extcode
Copy link
Owner

@extcode extcode commented Jun 10, 2024

I added two rector rules to skip list, because they change the order of constructor arguments or replace injector methods in the abstract ActionController class.

Fixes: #530

@extcode extcode requested a review from rintisch June 10, 2024 20:57
@extcode extcode self-assigned this Jun 10, 2024
Copy link
Collaborator

@rintisch rintisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments :)

Classes/Controller/Cart/ActionController.php Outdated Show resolved Hide resolved
Classes/Domain/Model/Order/ProductAdditional.php Outdated Show resolved Hide resolved
Classes/Domain/Model/Order/Tax.php Outdated Show resolved Hide resolved
@extcode extcode merged commit 69db21e into main Jun 11, 2024
10 checks passed
@extcode extcode deleted the 530-change-rector-configuration-and-run branch October 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change rector configuration and run
2 participants