[steps] Do not trim step output value #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szdziedzic
approved these changes
Jan 23, 2025
Base automatically changed from
stanley/eng-14784-hide-warning-about-missing-output-spec
to
main
January 23, 2025 13:17
sjchmiela
force-pushed
the
stanley/do-not-trim-output-value
branch
from
83f9de3 to
51a3ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I think we've been doing
.trim()on output values because of plainechoinset-output.How
Added
-ntoecho, removed.trim(). Then changed to use Base64 encoding as we do for environment variables.Test Plan
Adjusted test. It was wrong all along! Passing of the rest of existing steps confirms steps work in general, right?