[steps] Add better workflow support for if condition #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szdziedzic
approved these changes
Jan 17, 2025
| @@ -308,17 +308,14 @@ export class BuildStep extends BuildStepOutputAccessor { | |||
|
|
|||
| let ifCondition = this.ifCondition; | |||
|
|
|||
| if (ifCondition.startsWith('${') && ifCondition.endsWith('}')) { | |||
| if (ifCondition.startsWith('${{') && ifCondition.endsWith('}}')) { | |||
There was a problem hiding this comment.
do we allow for ${{ sth }} pattern in other places like inside of run? If we don't it's strange to support it only for if
| @@ -331,6 +328,7 @@ export class BuildStep extends BuildStepOutputAccessor { | |||
| runtimePlatform: this.ctx.global.runtimePlatform, | |||
| ...this.ctx.global.staticContext, | |||
| }, | |||
| ...this.getInterpolationContext(), | |||
There was a problem hiding this comment.
this includes deleted things, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to support
ifconditions on individual steps in workflows.How
ifConditionifConditionStepZZod schema so we can replacewwwcopies with using upstreamTest Plan
Added some tests.