Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-tools] resolve correct projectRootDirectory during eas build:internal #495

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Jan 16, 2025

Why

We resolve incorrect and override projectRootDirectory when running eas build:internal for GCS builds that use NoVcsClient in EAS CLI as VCS client. Adding EAS_PROJECT_ROOT env var should fix it.

How

Use EAS_PROJECT_ROOT env var if EAS_NO_VCS is used

Test Plan

Tests

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic requested a review from sjchmiela January 16, 2025 12:24
@szdziedzic szdziedzic marked this pull request as ready for review January 16, 2025 12:24
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we always pass EAS_PROJECT_ROOT (no matter EAS_NO_VCS)? I think we can expect ctx.buildDirectory / ctx.projectTargetDirectory to always be correct?

Also, why buildDirectory in one place and projectTargetDirectory in the other?

@szdziedzic
Copy link
Member Author

buildDirectory is a place where project archive is located in "standard" build process and projectTargetDirectory is the place where project archive lands after checkout is done for custom builds

@szdziedzic
Copy link
Member Author

Could we always pass EAS_PROJECT_ROOT (no matter EAS_NO_VCS)? I think we can expect ctx.buildDirectory / ctx.projectTargetDirectory to always be correct?

I played it safely in case it has some unknown side effects :D

@szdziedzic szdziedzic merged commit 3f0413f into main Jan 16, 2025
5 checks passed
@szdziedzic szdziedzic deleted the 01-16-_build-tools_resolve_correct_projectrootdirectory_during_eas_build_internal branch January 16, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants