Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] allow running eas/build function group with credentials for iOS GH builds #480

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Dec 17, 2024

Why

We are making a decision in our system whether to execute the credentials or without the credentials flow for the iOS eas/build function group based on the presence of job.secrets.buildCredentials. However, at the time of making this discussion (before the build starts), these are always missing for GH builds and are only resolved later.

We should rely on job.simulator only instead, which is always correctly set for GH builds https://github.com/expo/universe/blob/9eccb36e30da89e17d1c8b748437da99faebfa7d/server/www/src/data/entities/github/GitHubBuildUtils.ts#L165

How

Only use job.simulator to decide which flow to enter

Test Plan

Test it manually

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic requested a review from sjchmiela December 17, 2024 14:17
@szdziedzic szdziedzic marked this pull request as ready for review December 17, 2024 14:17
@szdziedzic szdziedzic merged commit cff4555 into main Dec 20, 2024
5 checks passed
@szdziedzic szdziedzic deleted the 12-17-_eas-cli_allow_running_eas_build_function_group_with_credentials_for_ios_gh_builds branch December 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants