[eas-cli] allow running eas/build function group with credentials for iOS GH builds #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We are making a decision in our system whether to execute the credentials or without the credentials flow for the iOS
eas/build
function group based on the presence ofjob.secrets.buildCredentials
. However, at the time of making this discussion (before the build starts), these are always missing for GH builds and are only resolved later.We should rely on
job.simulator
only instead, which is always correctly set for GH builds https://github.com/expo/universe/blob/9eccb36e30da89e17d1c8b748437da99faebfa7d/server/www/src/data/entities/github/GitHubBuildUtils.ts#L165How
Only use
job.simulator
to decide which flow to enterTest Plan
Test it manually