[steps] [ENG-14373] Fix multiline slack messages with env vars #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added quotes around the env var value when saving it into the file. The reason for it is that if you set the env value to something like "line 1 line 2 line 3" without the quotes it would remove the implicit new-line characters and save it as 1 line See: https://linear.app/expo/issue/ENG-14373/fix-multiline-slack-message-from-env-vars
Added an util function to replace the doubly backslashed escape character in the raw env value with actual escape characters See: https://linear.app/expo/issue/ENG-14373/fix-multiline-slack-message-from-env-vars
Used the previously added function to fix the escape characters when reading the raw env value from the file and updating the context See: https://linear.app/expo/issue/ENG-14373/fix-multiline-slack-message-from-env-vars
radoslawkrzemien
requested review from
szdziedzic and
sjchmiela
as code owners
szdziedzic
approved these changes
Dec 13, 2024
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-14373_fix_multiline_slack_messages_with_env_vars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo/eas-cli#2728
When setting an env var to a multiline string and then passing it as the context of a Slack message to the
eas/send_slack_messagefunction the new-line characters are not correctly handled. The implicit new-lines are removed, while explicit\ncharacters are used as\andn.How
Updated the
set-envbash script to preserve the implicit new-lines when saving the var value to the file.Added a util function that fixes the explicit escape characters when reading the raw env value from the file and updating the context.
Test Plan
Manual tests
Config
Before
After