added model kwargs support to AzureChAzureMLChatOnlineEndpoint #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Manikanta5112 thank you so much for putting this PR in! Could you fix the type error that is there? |
|
Hey @jjmachan, fixed the type error. pls check now |
|
this has been improved with v0.2, @Manikanta5112 did you get a chance to check it out 🙂 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open source chat models like llama2, has to instantiate through AzureMLChatOnlineEndpoint(azure_ml_endpoint)
currently, we are directly checking temperature parameter for self.llm. whereas models instantiated through (azure_ml_endpoint) doesn't contain that parameter.
whereas it exist as dictionary under model_kwargs.
so, added support for this.