Refactor hallucination score calculation in _faithfulness.py #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Yongtae723 , thanks for the changes. I would prefer to add this to communicate the message via a short comment instead of changing the variable name. Does that make sense? |
jjmachan
pushed a commit
that referenced
this pull request
Nov 24, 2023
|
@Yongtae723 This has been addressed in #333 . Thanks a lot for bringing this issue to out notice :) Keep up the good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of score goes back and forth and confuses newcomer.
This issue related to discussion on discord