-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed module names and made changes in init to reflect the change #244
Renamed module names and made changes in init to reflect the change #244
Conversation
tinomaxthayil
commented
Nov 1, 2023
- Changed module names to _contexts, _context_recall, _faithfullness
- Changed faithfulness module name in answer_correctness.py
- Added the new names to init.py
|
yes check the documentation on how we are importing it and add tests that mimic that. |
|
src/ragas/metrics/__init__.py
Outdated
from ragas.metrics._contexts import ( | ||
ContextPrecision, | ||
ContextRelevancy, | ||
context_precision, | ||
context_relevancy, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinomaxthayil and @shahules786 should we split this into 2 files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you meant Class and instance for _contexts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjmachan Not sure what is ideal here, since both are metrics to evaluate contexts, I would suggest to keep as it is.
@jjmachan and @shahules786. There were _context_precision and _contexts with the same metrics from another push I assume. I split it into two files and made the init changes. The new files are _contexts and _context_relevancy |
src/ragas/metrics/_contexts.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should now be _context_precision