-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance langgraph integration to preserve metadata #1878
base: main
Are you sure you want to change the base?
Enhance langgraph integration to preserve metadata #1878
Conversation
thanks a lot @i-w-a for contributing this 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think making a completely new function for handling metadata might not be the most efficient approach. It could be more effective to enhance the existing convert_to_ragas_messages
function by incorporating metadata extraction into it by default.
This way, we could avoid redundancy.
what about deleting the old one and replacing it with this @sahusiddharth - would that be easier? or will we loose functionality? |
Sure, we can do that. There won’t be any change in functionality. |
Thank you for your comment! |
@i-w-a, Yes, please keep the function name as |
c44645f
to
07852f6
Compare
Hi team, I'm facing test failures and would appreciate your help.
Any guidance on these issues would be greatly appreciated. Thanks, |
@i-w-a, It seems that the test cases are failing because of a previous PR that modified the output of the error message triggered by the assertion error. I have just raised a PR that will fix it. |
@sahusiddharth |
Enhance langgraph integration to preserve AI metadata
Description
This PR updates the
langgraph.py
integration to ensure that metadata are preserved. This enhancement is crucial for multi-agent scenarios where identifying the source AI is important for evaluation.Changes
langgraph.py
to ensure AI names and metadata are preserved.Motivation and Context
In the current implementation, metadata such as the name assigned to an AI is not saved. In the era of multi-agent systems, it is essential to have information about which AI made a particular statement for accurate evaluation. This update addresses this issue by preserving the necessary metadata.
Example Code and Output