Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the documentation in the migration docs #1873

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

sahusiddharth
Copy link
Collaborator

The current example would have caused a KeyError: 'retrieved_contexts' because the retrieved_contexts key was missing in the SingleTurnSample which is a required column in Faithfulness metric.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@jjmachan
Copy link
Member

nice catch @sahusiddharth ❤️

@jjmachan jjmachan merged commit eb30c50 into explodinggradients:main Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants