fix(prompt/mixin): Add name property and add it to saving/loading path. #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
size:S
jjmachan
approved these changes
Jan 22, 2025
|
I'll merge this in after you have a look at it and approve @tim-hilde |
sahusiddharth
pushed a commit
to sahusiddharth/ragas
that referenced
this pull request
Jan 24, 2025
…h. (explodinggradients#1853) This pull request includes several changes to the `PromptMixin` class in the `src/ragas/prompt/mixin.py` file. The changes focus on adding a `name` attribute to the class and using this attribute when saving and loading prompts. This solves the error when saving and loading several prompts of different Synthesizers (e.g. MultiHopAbstractQuerySynthesizer, MultiHopSpecificQuerySynthesizer, SingleHopSpecificQuerySynthesizer etc.) as they had the same path associated: ``` themes_personas_matching_prompt_english -> single_hop_specifc_query_synthesizer_themes_personas_matching_prompt_english query_answer_generation_prompt_english -> single_hop_specifc_query_synthesizer_query_answer_generation_prompt_english ``` ### Changes to `PromptMixin` class: * Added a `name` attribute to the `PromptMixin` class. * Modified the `save_prompts` method to include the `name` attribute in the prompt file name. * Modified the `load_prompts` method to include the `name` attribute in the prompt file name. --------- Co-authored-by: jjmachan <[email protected]> Co-authored-by: Jithin James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
PromptMixinclass in thesrc/ragas/prompt/mixin.pyfile. The changes focus on adding anameattribute to the class and using this attribute when saving and loading prompts. This solves the error when saving and loading several prompts of different Synthesizers (e.g. MultiHopAbstractQuerySynthesizer, MultiHopSpecificQuerySynthesizer, SingleHopSpecificQuerySynthesizer etc.) as they had the same path associated:Changes to
PromptMixinclass:nameattribute to thePromptMixinclass.save_promptsmethod to include thenameattribute in the prompt file name.load_promptsmethod to include thenameattribute in the prompt file name.