Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rubrics based metrics #1821

Conversation

sahusiddharth
Copy link
Collaborator

@sahusiddharth sahusiddharth commented Jan 8, 2025

@sahusiddharth sahusiddharth marked this pull request as ready for review January 8, 2025 14:06
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 8, 2025
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ragas/metrics/_domain_specific_rubrics.py Outdated Show resolved Hide resolved
Co-authored-by: ikka <[email protected]>
@jjmachan jjmachan linked an issue Jan 8, 2025 that may be closed by this pull request
Co-authored-by: ikka <[email protected]>
@shahules786 shahules786 changed the title fixes: The Rubric-Based Criteria Scoring Metric fix: rubrics based metrics Jan 8, 2025
@sahusiddharth sahusiddharth requested a review from jjmachan January 8, 2025 15:03
Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jjmachan jjmachan merged commit c0dc689 into explodinggradients:main Jan 8, 2025
15 checks passed
@sahusiddharth sahusiddharth deleted the feat/fixing_domain_specific_rubrics branch January 8, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do the scores for rubric have to be numeric and in a 1-5 range?
3 participants