wrap as_complete with async #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally as_complete is not defined with async, the asyncio.Semaphore is created in main thread not in asynci.run. This will cause 'There is no event loop' error when: 1. len(coros) is more than max_workers; 2. run 'evalute' function at the second time and nest_asyncio is not applied.
dosubot
bot
added
the
size:XS
add await to as_completed test code in test_executor_in_jupyter.ipynb
|
@liupgd thanks a lot for putting this PR together 🙂 let me just benchmark it on my end too before merging it in |
|
thanks a lot @liupgd ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally as_complete is not defined with async, the asyncio.Semaphore is created in main thread not in asynci.run. This will cause 'There is no event loop' error when: