fix(sc-105769): ensure internal IP is set when there is only public one #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeChepy
approved these changes
Sep 24, 2024
nerzhul
force-pushed
the
feat/lblot/sc-105769
branch
from
c7d727c to
cddda03
Compare
|
The CI fails because of a fmt issue. |
|
@PhilippeChepy fixed the formatting |
zyegfryed
approved these changes
Sep 24, 2024
ned-si
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
(For exoscale contributors)
Testing
Added coverage for all cases we need and fix tests which now require to add this bugfix in the result