Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump kubernetes sdk from 0.30.2 to 0.31.0 #91

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

zyegfryed
Copy link
Member

@zyegfryed zyegfryed commented Sep 4, 2024

Description

Also bumps Golang from 1.22 to 1.23

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

✅ Ran unit test locally:

▶ gmake test
go.mk/version.mk:13: warning: overriding recipe for target 'get-version-tag'
/Users/zyegfryed/src/github.com/exoscale/exoscale-cloud-controller-manager/go.mk/version.mk:13: warning: ignoring old recipe for target 'get-version-tag'
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 7 (delta 4), reused 7 (delta 4), pack-reused 0 (from 0)
Unpacking objects: 100% (7/7), 822 bytes | 137.00 KiB/s, done.
From https://github.com/exoscale/go.mk
 + 65beabd...5baff22 philippsauter/sc-100477/ci-automate-changelog-md-on-release-process -> origin/philippsauter/sc-100477/ci-automate-changelog-md-on-release-process  (forced update)
go.mk/version.mk:13: warning: overriding recipe for target 'get-version-tag'
/Users/zyegfryed/src/github.com/exoscale/exoscale-cloud-controller-manager/go.mk/version.mk:13: warning: ignoring old recipe for target 'get-version-tag'
'/opt/homebrew/bin/go' test \
  -race \
  -timeout 15s \
   \
  github.com/exoscale/exoscale-cloud-controller-manager/exoscale
ok      github.com/exoscale/exoscale-cloud-controller-manager/exoscale  5.803s

🛑 Ran acceptance test locally: tests are failing to find version 1.31, run twice the 5xx suite and hang indefinitely without releasing resources.

▶ ./run -t sks
INFO[run]: Running test type 'sks'
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.12.5, pytest-8.3.2, pluggy-1.5.0
rootdir: /Users/zyegfryed/src/github.com/exoscale/exoscale-cloud-controller-manager/test
configfile: pytest.ini
collected 69 items / 1 deselected / 68 selected

tests_0_environment/test_001_environment.py .....                                                                                                      [  7%]
tests_1_control_plane/test_101_control_plane.py .                                                                                                      [  8%]
tests_1_control_plane/test_102_control_plane_files.py ......                                                                                           [ 17%]
tests_1_control_plane/test_103_control_plane_start.py F.                                                                                               [ 20%]
tests_2_nodes/test_201_nodes.py .                                                                                                                      [ 22%]
tests_2_nodes/test_202_nodes_files.py s.                                                                                                               [ 25%]
tests_3_ccm/test_300_init.py .                                                                                                                         [ 26%]
tests_3_ccm/test_301_k8s_state.py ..                                                                                                                   [ 29%]
tests_3_ccm/test_302_ccm_start.py .....                                                                                                                [ 36%]
tests_3_ccm/test_303_ccm_node_csr_validation.py .                                                                                                      [ 38%]
tests_3_ccm/test_304_ccm_node_csr_invalid.py ss                                                                                                        [ 41%]
tests_3_ccm/test_305_ccm_nodes.py x                                                                                                                    [ 42%]
tests_3_ccm/test_306_ccm_api_credentials_update.py ..                                                                                                  [ 45%]
tests_3_ccm/test_307_k8s_nodes.py x.x                                                                                                                  [ 50%]
tests_4_nlb/test_400_init.py ..                                                                                                                        [ 52%]
tests_4_nlb/test_401_nlb_hello_external.py .....                                                                                                       [ 60%]
tests_4_nlb/test_402_nlb_ingress_nginx.py .......                                                                                                      [ 70%]
tests_4_nlb/test_403_nlb_hello_ingress.py ..                                                                                                           [ 73%]
tests_5_nodes_pool_resize/test_500_init.py ..                                                                                                          [ 76%]
tests_5_nodes_pool_resize/test_501_k8s_state.py ...                                                                                                    [ 80%]
tests_5_nodes_pool_resize/test_502_ccm_nodes_deletion.py s                                                                                             [ 82%]
tests_5_nodes_pool_resize/test_503_ccm_nodes_csr_validation.py .                                                                                       [ 83%]
tests_5_nodes_pool_resize/test_504_k8s_nodes.py .                                                                                                      [ 85%]
tests_5_nodes_pool_resize/test_505_nlb_hello.py ..                                                                                                     [ 88%]
tests_5_nodes_pool_resize/test_501_k8s_state.py ...                                                                                                    [ 92%]
tests_5_nodes_pool_resize/test_502_ccm_nodes_deletion.py X                                                                                             [ 94%]
tests_5_nodes_pool_resize/test_503_ccm_nodes_csr_validation.py s                                                                                       [ 95%]
tests_5_nodes_pool_resize/test_504_k8s_nodes.py .                                                                                                      [ 97%]
tests_5_nodes_pool_resize/test_505_nlb_hello.py ..^C

========================================================================== FAILURES ==========================================================================
______________________________________________________________________ test_k8s_version ______________________________________________________________________

test = {'directory': '/Users/zyegfryed/src/github.com/exoscale/exoscale-cloud-controller-manager/test', 'state': {'ccm': {'st...{'service': {'healthcheck': {'success': 120}, 'start': 180}, 'start': 120}, 'node': {'delete': 60, 'start': 180}}, ...}
tf_control_plane = <tftest.TerraformValueDict object at 0x105359df0>, logger = <Logger test-ccm (WARNING)>

    @pytest.mark.control_plane
    def test_k8s_version(test, tf_control_plane, logger):
        (iExit, sStdOut, sStdErr) = kubectl(
            [
                "--output=json",
                "version",
            ],
            kubeconfig=tf_control_plane["kubeconfig_admin"],
        )
        assert iExit == 0
        output = json.loads(sStdOut)
        version = output["serverVersion"]["gitVersion"]
        logger.info(f"[K8s] Kubernetes version: {version}")

        version_major_minor = "%s.%s" % (
            output["serverVersion"]["major"],
            output["serverVersion"]["minor"],
        )
>       assert version_major_minor in ["1.28", "1.29", "1.30"]
E       AssertionError: assert '1.31' in ['1.28', '1.29', '1.30']

tests_1_control_plane/test_103_control_plane_start.py:25: AssertionError
================================================================== short test summary info ===================================================================
FAILED tests_1_control_plane/test_103_control_plane_start.py::test_k8s_version - AssertionError: assert '1.31' in ['1.28', '1.29', '1.30']
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! KeyboardInterrupt !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
/Users/zyegfryed/.local/share/uv/python/cpython-3.12.5-macos-aarch64-none/lib/python3.12/selectors.py:415: KeyboardInterrupt
(to show a full traceback on KeyboardInterrupt use --full-trace)
================================== 1 failed, 58 passed, 5 skipped, 1 deselected, 3 xfailed, 1 xpassed in 2212.60s (0:36:52) ==================================

@zyegfryed zyegfryed self-assigned this Sep 4, 2024
@zyegfryed zyegfryed marked this pull request as ready for review September 4, 2024 12:47
Copy link
Member

@llambiel llambiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyegfryed zyegfryed added the HOLD ✋ Hold, don't merge (no review queue) label Sep 5, 2024
@zyegfryed zyegfryed merged commit 108877a into master Sep 23, 2024
1 check passed
@zyegfryed zyegfryed deleted the zyegfryed/sc-103446/ccm-kubernetes-sdk-0-31 branch September 23, 2024 15:51
@PhilippeChepy PhilippeChepy removed the HOLD ✋ Hold, don't merge (no review queue) label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants