-
Notifications
You must be signed in to change notification settings - Fork 3
XR Search autocomplete #55
base: master
Are you sure you want to change the base?
Conversation
In-world UX
Update README.md
I like the dark UI from Chrome. Also, the prismy url bar is really noisy and we should probably make it just a flat color. |
So is it the same as Google's results for autocomplete or is it closer to a more privacy endorsed search engine which is the same as to say it's closer to duckduckgo? |
It's neither, I think right now it's a custom crawl. |
Really! That sounds awesome! |
}; | ||
const _autoCompleteSearch = s => { | ||
const url = 'http://13.56.80.83:9200/voxel/_search?q=' + s + '&pretty=true'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be a constant.
@@ -3870,12 +3871,60 @@ | |||
const index = keyboardFocus.caretMesh.getValue(); | |||
keyboardFocus.textMesh.setText(s.slice(0, index) + c + s.slice(index)); | |||
keyboardFocus.caretMesh.setValue(index + 1); | |||
|
|||
_autoCompleteSearch(keyboardFocus.textMesh.getText()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to always autocomplete on every single mode of the label mesh? In particular I think it might not make sense for the 2D browser mesh case.
@chrisplatorres Is this one indexing/going to index the exokit examples? I'd like to pull that out into a separate repo/site and index it in the usual way so it's not included as bloat in every shipment of exokit engine. |
I agree that it would be a good idea to pull out the examples and then index them. Will do, we could host it on a gh-pages in its own repo. |
Yeah, I was thinking something inspired by https://threejs.org/examples/. (But it doesn't need to be pretty, only accessible from the frontend, and I think the best way to do that is to crawl it) |
ce5284c
to
b294cb4
Compare
This PR proposes a list of search results that appear above the url bar when a user types. This is similar to current browsers:
This is hooked up to an elasticsearch server that crawls and indexes eventually all XR content found on the web.
There could be less reliance on the centralized results and have the results be more personal in the future like current browsers do with showing bookmarks / search history.
Current result example: