This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
Toggle DOM view #38
Open
Toggle DOM view #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add root package.json
Add basic README
merge in fork master
Default viewport vector to all zeroes
Engine render green screen
Green screen compose
Hide controller ray when in orbit controls mode
Remove console resizing
Remove kitchen sink example from dropdown
Make iframe dropdown overlay
Send mouse movements to html
|
|
This might be dropped in favor of integrating devtools instead. This will replace the DOM view, console, etc. Will also add performance tracking and adding a debugger. |
avaer
reviewed
Jun 15, 2019
| @@ -127,6 +142,7 @@ class DomList extends React.Component { | |||
|
|
|||
| this.state = { | |||
| hoverEl: null, | |||
| domView: this.props.domView, | |||
There was a problem hiding this comment.
It's generally not good practice to latch props onto state.
Do we need to do this or could we just thread the props through?
avaer
force-pushed
the
master
branch
3 times, most recently
from
ce5284c to
b294cb4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #32 and adds a button to toggle between "DOM" and "layers" view modes on the right sidebar.
To-do: