Changes in RationalTest.java #2889
Conversation
Correcting the error I made in (exercism#2886). no important files changed
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| @@ -8,10 +8,10 @@ public class RationalTest { | |||
|
|
|||
| // Helper methods | |||
|
|
|||
| private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-15; | |||
| private static final double DOUBLE_EQUALITY_TOLERANCE = 2e-15; | |||
There was a problem hiding this comment.
Having a look around at how other tracks handle this, I'm wondering if we really need that much accuracy. For example, in the Python track, I think it is checked up to 8 places. What do you think about using 1e-8 for the tolerance?
There was a problem hiding this comment.
Yeah, I think it's alright. I'm gonna change it to 1e-8.
There was a problem hiding this comment.
@stamatisn do you plan to make this change as @kahgoh suggested?
There was a problem hiding this comment.
Sorry, I had some things to do these past days and I really forgot to do it. I will have it ready in a minute
Changes float tolerance from 2e-15 to 1e-8 as told in (exercism#2889)
Correcting the error I made in (#2886).
no important files changed
Fixes #2823
Reviewer Resources:
Track Policies