feat(esl-anchornav): create esl-anchornav to provide anchor navigation #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshovchko
requested review from
ala-n,
yadamskaya,
abarmina,
Natalie-Smirnova,
fshovchko,
HenadzV,
NastaLeo and
a team
ala-n
approved these changes
Aug 11, 2024
| public set sticked(value: boolean) { | ||
| if (this._sticked === value) return; | ||
| this._sticked = value; | ||
| this.$$attr('sticked', value); |
There was a problem hiding this comment.
It doesn't sound good to have potentially conflicting marker attributes. Do we really need it ?
There was a problem hiding this comment.
Yes, we need marker for sticky state styling
NastaLeo
approved these changes
Aug 12, 2024
ala-n
approved these changes
Aug 13, 2024
| if (y <= topBoundary) active = item; | ||
| }); | ||
| if (active) { | ||
| this._items.forEach(($item, id) => $item.classList.toggle('active', id === active.id)); |
There was a problem hiding this comment.
For wave 2: customization for active class
…3309 test(e2e): update snapshots (via GitHub Actions) for refs/heads/feat/esl-anchornav
abarmina
approved these changes
Aug 13, 2024
ala-n
approved these changes
Aug 13, 2024
|
🎉 This issue has been resolved in version 5.0.0-beta.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2578