Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Rename "runtime" to "platform" #458

Merged
merged 2 commits into from
Dec 22, 2024
Merged

all: Rename "runtime" to "platform" #458

merged 2 commits into from
Dec 22, 2024

Conversation

camh-
Copy link
Member

@camh- camh- commented Dec 19, 2024

Rename uses of "runtime" where it refers to the CLI runtime and the browser
runtime to "platform". Runtime usually refers to the thing doing the
running, such as the evaluator or bytecode VM and has started to cause a
little confusion or cumbersome language now that the bytecode VM is being
developed. Initial talk of perhaps targeting micro-controllers as
"platforms" also suggests this should be called platform.

There are still a few uses of the word "runtime" left - these refer to
things like "runtime errors" where the term still makes sense, as it does
not refer to the Evy abstraction for runtime/platform.

Fix a lint error in learn/pkg/learn/markdown.go since golangci-lint wants
to complain about this now.

Copy link
Member

@juliaogris juliaogris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I checked out the branch and double checked all remaining uses of "runtime" and they seem a lot more fitting now.

Thank you!

Rename uses of "runtime" where it refers to the CLI runtime and the
browser runtime to "platform". Runtime usually refers to the thing doing
the running, such as the evaluator or bytecode VM and has started to
cause a little confusion or cumbersome language now that the bytecode VM
is being developed. Initial talk of perhaps targeting micro-controllers
as "platforms" also suggests this should be called platform.

There are still a few uses of the word "runtime" left - these refer to
things like "runtime errors" where the term still makes sense, as it
does not refer to the Evy abstraction for runtime/platform.

Fix a lint error in `learn/pkg/learn/markdown.go` since golangci-lint
wants to complain about this now.

Commit-group: 1/2
Update generated docs from changes to source material.

Commit-group: 2/2
Gen-command: make docs
@camh- camh- force-pushed the rename-runtime-to-platform branch from baf2681 to 9f1458d Compare December 22, 2024 07:50
@camh- camh- merged commit c3e485d into main Dec 22, 2024
4 checks passed
@camh- camh- deleted the rename-runtime-to-platform branch December 22, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants