Exclude .ninja_lock from VCS tracking #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
added a commit
that referenced
this pull request
Jan 10, 2025
The idea here was probably to avoid wasting CI time... but it prevents minor changes, like #637, from being merged because all build workflows are required checks. GitHub's branch protection feature is clearly half-baked, so there's no way around it right now. Luckily minor changes like these virtually never happen, so for the time being it shouldn't be a big problem to remove this setting.
rdw-software
added a commit
that referenced
this pull request
Jan 10, 2025
The idea here was probably to avoid wasting CI time... but it prevents minor changes, like #637, from being merged because all build workflows are required checks. GitHub's branch protection feature is clearly half-baked. Luckily minor changes like these virtually never happen, so for the time being it shouldn't be a big problem to remove this setting.
rdw-software
force-pushed
the
gitignore-ninja-lockfile
branch
from
0ba5977 to
cbc63dc
Compare
rdw-software
changed the title
It's usually deleted before git will even see it, but removing any potential for this to be committed seems better.
rdw-software
force-pushed
the
gitignore-ninja-lockfile
branch
from
cbc63dc to
40a283e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's usually deleted before git will even see it, but removing any potential for this to be committed seems better.