Replace the Lua implementation of stbi.replace_pixel_color_rgba with a C++ version #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the old Lua implementation for reference (it's slow).
rdw-software
force-pushed
the
stbi-replace-colors
branch
from
a2b6022 to
5cfae13
Compare
It's a bit silly doing low-level pixel manipulation in Lua when it's 10x slower with zero benefits to offset the cost.
rdw-software
force-pushed
the
stbi-replace-colors
branch
from
5cfae13 to
846b9da
Compare
rdw-software
changed the title
rdw-software
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing, but significantly faster. Probably not all that relevant, but there's no reason to not take the easy win here.