Add FFI bindings for some of the C++ standard library bit operations (from the Numerics library) #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
cpp-ffi-bitops
branch
2 times, most recently
from
fc38c32 to
d78053b
Compare
These seem to be about 10 times as fast as a Lua implementation (jn microbenchmarks), amounting to a 5% performance increase in some of the code I've been running.
rdw-software
force-pushed
the
cpp-ffi-bitops
branch
from
d78053b to
251d3a2
Compare
It seems that the return type was changed retroactively, which isn't reflected in the GCC and clang versions installed on GitHub's runners? Either way, just dereferencing the function itself won't compile in that environment. It might be sensible to upgrade the installed toolchain in the CI runner, but that'll increase build times even more. It's prudent to test that the build proceeds with "older" versions of the supported toolchains anyway, as well as the relatively recent ones used by MSYS on Windows (which seems to have no issue here).
rdw-software
force-pushed
the
cpp-ffi-bitops
branch
from
251d3a2 to
a666260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be much faster than Lua versions, resulting in a 10x speedup in the micro-benchmark (and ~5% in real code).