Deduplicate the C definitions for static FFI exports to make the bindings easier to maintain #506
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Feb 12, 2024 in 30s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
Details
Annotations
Check notice on line 1 in Runtime/LuaVirtualMachine.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 70.00% to 71.43%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in Runtime/LuaVirtualMachine.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: String Heavy Function Arguments
The ratio of strings in function arguments increases from 65.00% to 66.67%, threshold = 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.
Loading