Fix ASAN warnings due to (inconsequential) memory leaks in the main loop #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire shutdown sequence needs a bit of a rework, but it can wait.
These don't really matter as the app will shut down, but it's still noise.
I originally found new/delete to be more idiomatic, although it really doesn't matter in this case. Removing two lines is still a win, I guess?
It's an oversight; the handles are from uws and already dealt with.
rdw-software
force-pushed
the
356-shutdown-memory-leaks
branch
from
ad35e81 to
db1003e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary benefit to doing this in the first place is to eliminate the warnings in preparation for running sanitizers in the CI.